[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071121044711.GF995458@sgi.com>
Date: Wed, 21 Nov 2007 15:47:11 +1100
From: David Chinner <dgc@....com>
To: Christoph Lameter <clameter@....com>
Cc: Christoph Hellwig <hch@...radead.org>, ak@...e.de,
akpm@...ux-foundation.org, travis@....com,
Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
linux-kernel@...r.kernel.org
Subject: Re: [rfc 18/45] cpu alloc: XFS counters
On Tue, Nov 20, 2007 at 12:38:29PM -0800, Christoph Lameter wrote:
> On Tue, 20 Nov 2007, Christoph Hellwig wrote:
>
> > On Mon, Nov 19, 2007 at 05:11:50PM -0800, clameter@....com wrote:
> > > Also remove the useless zeroing after allocation. Allocpercpu already
> > > zeroed the objects.
> >
> > You still haven't answered my comment to the last iteration.
>
> And you have not read the discussion on that subject in the prior
> iteration between Peter Zilkstra and me.
Seeing as I didn't notice this patchest changed XFS (where's the cc?)
until I saw hch's question I'd appreciate a pointer to that discussion
as it's long been deleted from my mailbox.
FWIW, I happen to agree with Christoph (hch) that the shouting
macros are an ugly step backwards, esp. given that is replacing:
#define per_cpu_ptr(ptr, cpu) percpu_ptr((ptr), (cpu))
a set of lowercase macros....
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists