[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0711222053170.15336@artax.karlin.mff.cuni.cz>
Date: Thu, 22 Nov 2007 21:19:39 +0100 (CET)
From: Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>
To: Linus Torvalds <torvalds@...ux-foundation.org>
cc: LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] fix plip 1
Hi
netif_rx is meant to be called from interrupts because it doesn't wake up
ksoftirqd. For calling from outside interrupts, netif_rx_ni exists.
This patch fixes plip to use netif_rx_ni. It fixes the infamous error
"NOHZ: local_softirq_panding 08" that happens on some machines with NOHZ
and plip --- it is caused by the fact that softirq is pending and
ksoftirqd is sleeping.
Mikulas
diff -u -r linux-2.6.24-rc2/drivers/net/plip.c linux-2.6.24-test/drivers/net/plip.c
--- linux-2.6.24-rc2/drivers/net/plip.c 2007-11-06 22:57:46.000000000 +0100
+++ linux-2.6.24-test/drivers/net/plip.c 2007-11-22 21:11:28.000000000 +0100
@@ -663,7 +663,7 @@
case PLIP_PK_DONE:
/* Inform the upper layer for the arrival of a packet. */
rcv->skb->protocol=plip_type_trans(rcv->skb, dev);
- netif_rx(rcv->skb);
+ netif_rx_ni(rcv->skb);
dev->last_rx = jiffies;
dev->stats.rx_bytes += rcv->length.h;
dev->stats.rx_packets++;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists