linux-kernel - Re: Where is the interrupt going?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Nov 2007 10:36:55 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	niessner@....nasa.gov, Kyle McMartin <kyle@...artin.ca>,
	linux-kernel@...r.kernel.org
Subject: Re: Where is the interrupt going?

On Fri, 23 Nov 2007 02:58:55 +0100
Bartlomiej Zolnierkiewicz <bzolnier@...il.com> wrote:

> On Friday 23 November 2007, Alan Cox wrote:
> > On Thu, 22 Nov 2007 16:48:53 -0800
> > niessner@....nasa.gov wrote:
> > 
> > > 
> > > I tried the hammer and the problem persists.
> > 
> > See my earlier email - your driver registers the irq with IRQF_DISABLED
> > then never enables it.
> 
> As already explained by Kyle IRQF_DISABLED shouldn't matter here.
> 
> [ Nowadays IRQF_DISABLED only tells kernel/irq/handle.c::handle_IRQ_event()
>   to not enable local interrupts before calling your IRQ handler.
> 
>   I've recently removed IRQF_DISABLED from IDE after noticing this. ]

Bartlomiej is of course correct. Thats what you get for replying late at
night in a hurry.

I'm not sure IDE can work without it because you need to lock out the
timer events (old IDE doesn't handle this at all on SMP though so it
wants fixing properly anyway).

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/