linux-kernel - fs/cifs/cifsacl.c: check-after-use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20071124171631.GA6835@stusta.de>
Date:	Sat, 24 Nov 2007 18:16:31 +0100
From:	Adrian Bunk <bunk@...nel.org>
To:	sfrench@...ba.org
Cc:	linux-cifs-client@...ts.samba.org, linux-kernel@...r.kernel.org
Subject: fs/cifs/cifsacl.c: check-after-use

The Coverity checker spotted the following check-after-use in 
fs/cifs/cifsacl.c:

<--  snip  -->

...
static void parse_dacl(struct cifs_acl *pdacl, char *end_of_acl,
                       struct cifs_sid *pownersid, struct cifs_sid *pgrpsid,
                       struct inode *inode)
{
...
        if (end_of_acl < (char *)pdacl + le16_to_cpu(pdacl->size)) {
...                                                  ^^^^^^^^^^^
        if (!pdacl) {
...

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/