linux-kernel - Re: [2.6 patch] power_supply_{leds,sysfs}.c should #include "power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071125231900.GA19266@zarina>
Date:	Mon, 26 Nov 2007 02:19:00 +0300
From:	Anton Vorontsov <cbou@...l.ru>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] power_supply_{leds,sysfs}.c should #include
	"power_supply.h"

On Mon, Nov 05, 2007 at 06:07:45PM +0100, Adrian Bunk wrote:
> Every file should include the headers containing the prototypes for
> its global functions.

Applied to battery-2.6.git, thanks.

p.s.
Sorry for the delay, I've not been Cc'ed, so I've found out about
that patch by pure chance (through looking in the -mm series).

> Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
> ---
> 
>  drivers/power/power_supply_leds.c  |    2 ++
>  drivers/power/power_supply_sysfs.c |    2 ++
>  2 files changed, 4 insertions(+)
> 
> e34cc994731ec9102bf5b1c7d6585c0aa87d1fa2 
> diff --git a/drivers/power/power_supply_leds.c b/drivers/power/power_supply_leds.c
> index 7f8f359..80ca288 100644
> --- a/drivers/power/power_supply_leds.c
> +++ b/drivers/power/power_supply_leds.c
> @@ -12,6 +12,8 @@
>  
>  #include <linux/power_supply.h>
>  
> +#include "power_supply.h"
> +
>  /* Battery specific LEDs triggers. */
>  
>  static void power_supply_update_bat_leds(struct power_supply *psy)
> diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
> index 249f61b..e8ad1fd 100644
> --- a/drivers/power/power_supply_sysfs.c
> +++ b/drivers/power/power_supply_sysfs.c
> @@ -14,6 +14,8 @@
>  #include <linux/ctype.h>
>  #include <linux/power_supply.h>
>  
> +#include "power_supply.h"
> +
>  /*
>   * This is because the name "current" breaks the device attr macro.
>   * The "current" word resolves to "(get_current())" so instead of
> 

-- 
Anton Vorontsov
email: cbou@...l.ru
backup email: ya-cbou@...dex.ru
irc://irc.freenode.net/bd2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/