linux-kernel - bonding sysfs output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tznafjeu.fsf@szonett.ki.iif.hu>
Date:	Sun, 25 Nov 2007 16:12:57 +0100
From:	Wagner Ferenc <wferi@...f.hu>
To:	linux-kernel@...r.kernel.org
Cc:	wferi@...f.hu
Subject: bonding sysfs output

Hi,

Am I totally of the limit with the attached patch against
drivers/net/bonding/bond_sysfs.c?  I'd like to receive some comments,
as I'm not a kernel developer.

I propose it as a fix for trailing NULs and spaces like eg.

$ od -c /sys/class/net/bond0/bonding/slaves 
0000000   e   t   h   -   l   e   f   t       e   t   h   -   r   i   g
0000020   h   t      \n  \0
0000025

I'm afraid there're other problems with "++more++" handling, but let's
not consider those just yet.  Find the patch attached.  The first
hunks also renames buffer to buf, for consistency's shake.

The original version had varying behaviour for Not Applicable cases.
This patch also settles for empty files (not even a line feed) in
those cases, but I'm not sure about the general policy on this matter.

Regards,
Feri.

View attachment "bond_sysfs.patch" of type "text/x-diff" (6999 bytes)