linux-kernel - Re: [PATCH 05/27] rename open_namei() to open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071126143305.GA10266@infradead.org>
Date:	Mon, 26 Nov 2007 14:33:05 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	Dave Hansen <haveblue@...ibm.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org, miklos@...redi.hu,
	hch@...radead.org
Subject: Re: [PATCH 05/27] rename open_namei() to open_pathname()

On Thu, Nov 01, 2007 at 04:08:32PM -0700, Dave Hansen wrote:
> 
> open_namei() no longer touches namei's.  rename it
> to something more appropriate: open_pathname().

The name is quite non-descriptive.  What about just leaving it as
filp_open and merging this into the previous patches to avoid
the spurious renaming?

And btw, exported functions that get half-rewritten should always
grow a kerneldoc comment.  Then again this particular one really
shouldn't be exported, but that's for another series.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/