linux-kernel - Re: [PATCH] scatterlist: add more safeguards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071126144326.GC5050@kernel.dk>
Date:	Mon, 26 Nov 2007 15:43:26 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Tejun Heo <htejun@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scatterlist: add more safeguards

On Mon, Nov 26 2007, Tejun Heo wrote:
> Add more safeguards to protect against misinterpreting a chain entry
> as a normal scatterlist and vice-versa.
> 
> * Make sure the entry isn't a chain when assigning and reading a
>   normal sg.
> 
> * Clear offset and length when chaining.
> 
> Signed-off-by: Tejun Heo <htejun@...il.com>
> ---
> While converting libata to use chained-sg, I felt a bit insecure and
> added a few more safe guards.  Feel free to include or ignore them.

Looks sane, thanks Tejun! Will apply it.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/