linux-kernel - Re: enable dual rng on VIA C7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071125233949.f64b2ecd.akpm@linux-foundation.org>
Date:	Sun, 25 Nov 2007 23:39:49 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Udo van den Heuvel <udovdh@...all.nl>
Cc:	linux-kernel@...r.kernel.org, Michael Buesch <mb@...sch.de>
Subject: Re: enable dual rng on VIA C7

On Sun, 11 Nov 2007 19:49:08 +0100 Udo van den Heuvel <udovdh@...all.nl> wrote:

> Any reason why the second rng on the VIA C7 CPU is not enabled?
> 
> Kind regards,
> Udo
> 
> 
> [via-rng.patch  text/plain (634B)]
> --- old/drivers/char/hw_random/via-rng.c	2007-11-11 19:39:49.000000000 +0100
> +++ new/drivers/char/hw_random/via-rng.c	2007-11-11 19:40:41.000000000 +0100
> @@ -41,6 +41,7 @@
>  	VIA_STRFILT_ENABLE	= (1 << 14),
>  	VIA_RAWBITS_ENABLE	= (1 << 13),
>  	VIA_RNG_ENABLE		= (1 << 6),
> +	VIA_RNG_DUAL            = (1 << 9),
>  	VIA_XSTORE_CNT_MASK	= 0x0F,
>  
>  	VIA_RNG_CHUNK_8		= 0x00,	/* 64 rand bits, 64 stored bits */
> @@ -128,6 +129,7 @@
>  	lo &= ~(0x7f << VIA_STRFILT_CNT_SHIFT);
>  	lo &= ~VIA_XSTORE_CNT_MASK;
>  	lo &= ~(VIA_STRFILT_ENABLE | VIA_STRFILT_FAIL | VIA_RAWBITS_ENABLE);
> +	lo |= VIA_RNG_DUAL;
>  	lo |= VIA_RNG_ENABLE;
>  
>  	if (lo != old_lo)
> 

Does the patch work?

It's missing a signed-off-by:, btw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/