linux-kernel - Re: [Patch] mm/sparse.c: Improve the error handling for sparse_add_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071126191316.99CF.Y-GOTO@jp.fujitsu.com>
Date:	Mon, 26 Nov 2007 19:19:49 +0900
From:	Yasunori Goto <y-goto@...fujitsu.com>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	Dave Hansen <haveblue@...ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Rik van Riel <riel@...hat.com>,
	Christoph Lameter <clameter@....com>,
	Andrew Morton <akpm@...l.org>, linux-mm@...ck.org
Subject: Re: [Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()

Hi, Cong-san.

>  	ms->section_mem_map |= SECTION_MARKED_PRESENT;
>  
>  	ret = sparse_init_one_section(ms, section_nr, memmap, usemap);
>  
>  out:
>  	pgdat_resize_unlock(pgdat, &flags);
> -	if (ret <= 0)
> -		__kfree_section_memmap(memmap, nr_pages);
> +
>  	return ret;
>  }
>  #endif

Hmm. When sparse_init_one_section() returns error, memmap and 
usemap should be free.

Thanks for your fixing.

-- 
Yasunori Goto 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/