[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071127012622.3e3a6bd1.akpm@linux-foundation.org>
Date: Tue, 27 Nov 2007 01:26:22 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "rae l" <crquan@...il.com>
Cc: "Richard Knutsson" <ricknu-0@...dent.ltu.se>,
"Herbert Xu" <herbert@...dor.apana.org.au>,
linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
dengxw@....com, "Randy Dunlap" <randy.dunlap@...cle.com>,
"Joe Perches" <joe@...ches.com>
Subject: Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h
instead
On Tue, 27 Nov 2007 13:03:29 +0800 "rae l" <crquan@...il.com> wrote:
> -static void hexdump(unsigned char *buf, unsigned int len)
> +static inline void hexdump(unsigned char *buf, unsigned int len)
> {
> - while (len--)
> - printk("%02x", *buf++);
> -
> - printk("\n");
> + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET,
> + 16, 1,
> + buf, len, false);
> }
uninlining this function shrinks crypto/tcrypt.o's .text from 20,009 bytes
down to 19,701.
inlining is almost always wrong.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists