linux-kernel - Re: [PATCH 4/3] start the global /sbin/init with 0,0 special pids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1y7cjitx2.fsf@ebiederm.dsl.xmission.com>
Date:	Tue, 27 Nov 2007 08:34:33 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Pavel Emelyanov <xemul@...nvz.org>
Cc:	Oleg Nesterov <oleg@...sign.ru>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/3] start the global /sbin/init with 0,0 special pids

Pavel Emelyanov <xemul@...nvz.org> writes:

> Eric W. Biederman wrote:
>> Oleg Nesterov <oleg@...sign.ru> writes:
>> 
>>> As Eric pointed out, there is no problem with init starting with sid == pgid
>>> == 0, and this was historical linux behavior changed in 2.6.18.
>>>
>>> Remove kernel_init()->__set_special_pids().
>>>
>>> This change and the previous change in daemonize() mean that /sbin/init does
>>> not need the special "session != 1" hack in sys_setsid() any longer. We can't
>>> remove this check yet, we should cleanup copy_process(CLONE_NEWPID) first, so
>>> update the comment only.
>> 
>> I guess that works.  As long as we get there.  We just need one more patch
>> in this series to fix the copy_process(CLONE_NEWPID).
>
> I hope this will NOT be the fix that creates the namespace's 
> init with the pid == 0 ;)

No just with session == pgrp == (unchanged and thus with vpid 0).

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/