linux-kernel - Re: [PATCH 3/4] drivers/usb: Drop unnecessary continue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071127064809.GA7571@kroah.com>
Date:	Mon, 26 Nov 2007 22:48:09 -0800
From:	Greg KH <greg@...ah.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/4] drivers/usb: Drop unnecessary continue

On Wed, Nov 14, 2007 at 09:15:16AM +0100, Julia Lawall wrote:
> diff -u -p -b -B a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
> --- a/drivers/usb/host/isp116x-hcd.c 2007-10-22 11:25:24.000000000 +0200
> +++ b/drivers/usb/host/isp116x-hcd.c 2007-11-13 23:14:10.000000000 +0100
> @@ -918,7 +918,6 @@ static int isp116x_hub_status_data(struc
>   			      | RH_PS_OCIC | RH_PS_PRSC)) {
>   			changed = 1;
>   			buf[0] |= 1 << (i + 1);
> -			continue;
>   		}
>   	}
>   	spin_unlock_irqrestore(&isp116x->lock, flags);

Your email client is eating all the tabs and converting them to spaces,
making these patches very hard to apply.

I've fixed this one up by hand, but please, fix your email client for
future ones.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/