linux-kernel - Re: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Nov 2007 10:53:45 -0800
From:	Dave Hansen <haveblue@...ibm.com>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	Yasunori Goto <y-goto@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Rik van Riel <riel@...hat.com>,
	Christoph Lameter <clameter@....com>,
	Andrew Morton <akpm@...l.org>, linux-mm@...ck.org
Subject: Re: [Patch](Resend) mm/sparse.c: Improve the error handling for
	sparse_add_one_section()

On Tue, 2007-11-27 at 10:26 +0800, WANG Cong wrote:
> 
> @@ -414,7 +418,7 @@ int sparse_add_one_section(struct zone *
>  out:
>         pgdat_resize_unlock(pgdat, &flags);
>         if (ret <= 0)
> -               __kfree_section_memmap(memmap, nr_pages);
> +               kfree(usemap);
>         return ret;
>  }
>  #endif 

Why did you get rid of the memmap free here?  A bad return from
sparse_init_one_section() indicates that we didn't use the memmap, so it
will leak otherwise.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/