[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200711271129.46754.david-b@pacbell.net>
Date: Tue, 27 Nov 2007 11:29:46 -0800
From: David Brownell <david-b@...bell.net>
To: "eric miao" <eric.y.miao@...il.com>
Cc: "Linux Kernel list" <linux-kernel@...r.kernel.org>,
"Felipe Balbi" <felipebalbi@...rs.sourceforge.net>,
"Bill Gatliff" <bgat@...lgatliff.com>,
"Haavard Skinnemoen" <hskinnemoen@...el.com>,
"Andrew Victor" <andrew@...people.com>,
"Tony Lindgren" <tony@...mide.com>,
"Jean Delvare" <khali@...ux-fr.org>,
"Kevin Hilman" <khilman@...sta.com>,
"Paul Mundt" <lethal@...ux-sh.org>,
"Ben Dooks" <ben@...nity.fluff.org>
Subject: Re: [patch/rfc 1/4] GPIO implementation framework
On Tuesday 27 November 2007, eric miao wrote:
> status = chip->direction_input(chip, gpio);
> - if (status == 0)
> - clear_bit(gpio, chip->is_out);
> + if (status)
> + desc->is_out = 0;
You added that same bug in two places (direction_output too).
Only zero status means success; otherwise it's negative errno.
Clearly this patch wasn't tested at all.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists