[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LFD.0.9999.0711261929560.5869@woody.linux-foundation.org>
Date: Mon, 26 Nov 2007 19:32:54 -0800 (PST)
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>
cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fix plip 1
On Thu, 22 Nov 2007, Mikulas Patocka wrote:
>
> netif_rx is meant to be called from interrupts because it doesn't wake up
> ksoftirqd. For calling from outside interrupts, netif_rx_ni exists.
Argh. Can you _please_ use more useful subject lines than "fix plip 1/2"?
Those subject lines are what becomes the single-line description of the
problem, used by visualizers like gitk and gitweb. So "fix plip 1" is a
singularly bad such line!
Which is why it should be something like
Subject: [PATCH 1/2] plip: use netif_rx_ni() for packet receive
or similar.. (My scripts will then get rid of the stuff in brackets, so
all that is useful for giving information that is interesting while in
*email*, but not when actually applied as a patch)
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists