[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200711280153.38964.david-b@pacbell.net>
Date: Wed, 28 Nov 2007 01:53:38 -0800
From: David Brownell <david-b@...bell.net>
To: "eric miao" <eric.y.miao@...il.com>
Cc: "Linux Kernel list" <linux-kernel@...r.kernel.org>,
"Felipe Balbi" <felipebalbi@...rs.sourceforge.net>,
"Bill Gatliff" <bgat@...lgatliff.com>,
"Haavard Skinnemoen" <hskinnemoen@...el.com>,
"Andrew Victor" <andrew@...people.com>,
"Tony Lindgren" <tony@...mide.com>,
"Jean Delvare" <khali@...ux-fr.org>,
"Kevin Hilman" <khilman@...sta.com>,
"Paul Mundt" <lethal@...ux-sh.org>,
"Ben Dooks" <ben@...nity.fluff.org>, "Nicolas Pitre" <nico@....org>
Subject: Re: [patch/rfc 2.6.24-rc3-mm] gpiolib grows a gpio_desc
On Wednesday 28 November 2007, eric miao wrote:
> > +static void gpio_ensure_requested(struct gpio_desc *desc)
> > {
> > - int requested;
> > -
> > + if (!desc->requested) {
> > + desc->requested = 1;
> > + pr_warning("GPIO-%ld autorequested\n", gpio_desc - desc);
>
> produces a warning here about %ld,
It uses "%ld" since I got a warning with "%d". :(
Evidently a cast will be needed.
> and maybe you mean desc - gpio_desc??
Maybe. Either that or the "GPIO-" should be "GPIO"!
> Except for the above, I feel OK overall.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists