linux-kernel - Re: [2.6 patch] some overdue I2C driver removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071128200729.121dd793@hyperion.delvare>
Date:	Wed, 28 Nov 2007 20:07:29 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
Cc:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>,
	Adrian Bunk <bunk@...nel.org>, i2c@...sensors.org,
	linux-kernel@...r.kernel.org,
	Russell King <rmk+kernel@....linux.org.uk>
Subject: Re: [2.6 patch] some overdue I2C driver removal

On Wed, 28 Nov 2007 19:37:20 +0100, Lennert Buytenhek wrote:
> On Wed, Nov 28, 2007 at 11:23:57AM +0100, Jean Delvare wrote:
> (...)
> > As far as I can see, the ixp2000 platform also doesn't implement the
> > standard GPIO API yet, so of the 3 drivers that are about to be
> > removed, only i2c-ixp4xx can be removed without functionality loss at
> > the moment. Lennert, Russell, are there any plans to convert the
> > ixp2000 platform to use the generic GPIO layer?
> 
> No plans at this point from my side.
> 
> I'm not entirely sold on the GPIO API, but nevertheless I expect
> that ixp2000 will be converted sooner rather than later.
> 
> If you don't want people to use i2c-ixp2000 as an example for new
> code, maybe you can stick in a comment at the top of the file that
> says that what i2c-ixp2000 does isn't the Preferred(TM) way of doing
> it?

The driver is tagged DEPRECATED in Kconfig, that should be enough. Not
to mention that any new i2c bus driver has to go through me so I'd
intercept the offender anyway.

> (...)
> Sorry, I seem to have missed the addition of i2c-ixp2000 to
> feature-removal-schedule.txt.  I would have spoken up earlier if I
> had been aware of it being in there.
> 
> It seems odd to me to advocate removal of something which works fine
> and for which no functional replacement is available just because it
> doesn't conform to the Latest And Greatest API(TM).  That's like
> suggesting that Jan 1st 2009 we should rm -f all .c files that still
> reference the big kernel lock, or rm -f all ARM ports that don't
> use the clocksource/clockevent mechanism yet (which includes
> ixp2000 as well.)
> 
> Let's just remove i2c-ixp2000 when the GPIO API conversion happens, ok?

That's the plan, yes.

-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/