linux-kernel - Re: [PATCH 6/6] tick: add a missing dot in prink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <474E8669.6060409@cn.fujitsu.com>
Date:	Thu, 29 Nov 2007 17:29:13 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Frans Pop <elendil@...net.nl>
CC:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, trivial@...nel.org
Subject: Re: [PATCH 6/6] tick: add a missing dot in prink

Frans Pop wrote:
> Li Zefan wrote:
>> Add a missing '.' in prink information.
>> -			printk(" no tick device\n");
>> +			printk(" no tick device.\n");
> 
> I wonder if that is correct. CodingStyle says:
>                 Chapter 13: Printing kernel messages
>    [...]
>    Kernel messages do not have to be terminated with a period.
> 
> I personally think that rule could be made a bit stricter as for example
> dmesg output currently looks fairly inconsistent with some messages
> terminated with a period while most messages are not and have been wondering
> if I should file patches to _remove_ periods.
> 
> Maybe the rule should be changed to:
>    Kernel messages should not be terminated with a period, unless a single
>    message contains multiple sentences.
> ?

But why a kernel message should not be terminated with a period? It does no harm
at all. And if the message is a complete sentence, it's grammatical correct to
terminated with a period.

I think CodingStyle just says an ending period is not mandatory. It does not
discourage the ending period.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/