[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <p734pf59wf7.fsf@crumb.suse.de>
Date: 29 Nov 2007 11:29:48 +0100
From: Andi Kleen <andi@...stfloor.org>
To: Vegard Nossum <vegard.nossum@...il.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)
Vegard Nossum <vegard.nossum@...il.com> writes:
>
> - We properly flush TLB entries that change. This used to not be the case, and so we
For low values of "properly" @)
> + pte = lookup_address(addr);
> + change_page_attr(page, 1, __pgprot(pte->pte_low | _PAGE_VISIBLE));
> + __flush_tlb_one(addr);
That's not enough, you need to flush all CPUs.
Also when you don't call global_flush_tlb() eventually because c_p_a() will leak flush
objects over time.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists