linux-kernel - Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071129194416.GB15245@elte.hu>
Date:	Thu, 29 Nov 2007 20:44:16 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <ak@...e.de>, Chuck Ebbert <cebbert@...hat.com>,
	Roland McGrath <roland@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Jeremy Fitzhardinge <jeremy@...p.org>, zach@...are.com
Subject: Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

* Andi Kleen <andi@...stfloor.org> wrote:

> For i386 iirc Jeremy/Zach did the benchmarking and they settled on %fs 
> because it was faster for something (originally it was %gs too)

yep. IIRC, some CPUs only optimize %fs because that's what Windows uses 
and leaves Linux with %gs out in the cold. There's also a performance 
penalty for overlapping segment use, if the segment cache is single 
entry only with an additional optimization for NULL [which just hides 
the segment cache].

But if it's good for unification we could switch that to %gs again on 
32-bit. I was one of the people who advocated the use of the 'other' 
segment register, so that the hardware has less overlap, but clean and 
unified code trumps this concern. It shouldnt be an issue on reasonably 
modern CPUs anyway.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/