linux-kernel - Re: [patch] ata: ahci: Enclosure Management via LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Nov 2007 15:04:17 -0500
From:	Mark Lord <lkml@....ca>
To:	kristen.c.accardi@...el.com
Cc:	jeff@...zik.org, akpm@...ux-foundation.org,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] ata: ahci: Enclosure Management via LED

Kristen Carlson Accardi wrote:
> On Thu, 29 Nov 2007 13:16:07 -0500
> Mark Lord <lkml@....ca> wrote:
> 
>> Kristen wrote:
>> ...
>>> +	 * XXX will need Port Multiplier support
>> What's that all about ?
>>
> 
> I didn't have any hardware that had LED support as well as Port
> Multiplier, so I didn't implement port multiplier support for this.  I
> wasn't sure if it was better to just do it anyway, or leave it for when
> we actually have hardware that needs it.
..

Good.  So please replace the "XXX" comment with the better
explanation given in your posting above.  That'll make future
maintenance a lot less guessy.

Cheers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/