linux-kernel - Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Nov 2007 15:46:42 -0500
From:	Mark Lord <lkml@....ca>
To:	Greg KH <gregkh@...e.de>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...l.org>,
	linux-usb-devel@...ts.sourceforge.net,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to
 insert/remove race (v3)

Greg KH wrote:
> On Thu, Nov 29, 2007 at 03:25:04PM -0500, Mark Lord wrote:
>> (resending .. somebody trimmed the CC: list earlier)
>>
>> Greg KH wrote:
>>>>>> Mark Lord wrote:
>>>>>>> ..
>>>>>>>
>>>>>>> While doing insert/remove (quickly) tests on USB,
>>>>>>> I managed to trigger an Oops on 2.6.23.8 on a call
>>>>>>> to strlen() in make_class_name().
>> ...
>>
>>> I'll hold off on adding this patch for now.
>> ..
>>
>> Why?
>>
>> Bugs that result in Oops in core code (class.c) can bite
>> just about any subsystem that does hotplug, and should get
>> prompt attention.  Or so one might think.
> 
> And they have, the 2.6.24 kernel should have the correct fix for this
> problem, right?  The fact that you oopsed out in this function enabled
> people to find and fix the problem already.  Adding a BUG_ON() does the
> same exact thing :)
..

Well, actually BUG_ON() allows the system to continue running
while still not masking the issue.  But close enough.


> So again, the problem is in the higher up scsi layer, and that is where
> the problem should already be fixed.
..

Ahhh.. so you figure the Oops should also have been fixed
as part of the 2.6.24 SCSI fixes ?  That's what I was missing here.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/