linux-kernel - Re: [PATCH] Reduce stack used by lib/hexdump.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0711292206450.3089@fbirervta.pbzchgretzou.qr>
Date:	Thu, 29 Nov 2007 22:07:56 +0100 (CET)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	Joe Perches <joe@...ches.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Reduce stack used by lib/hexdump.c


On Nov 29 2007 13:02, Randy Dunlap wrote:
>> @@ -140,13 +140,20 @@ EXPORT_SYMBOL(hex_dump_to_buffer);
>>   * Example output using %DUMP_PREFIX_ADDRESS and 4-byte mode:
>>   * ffffffff88089af0: 73727170 77767574 7b7a7978 7f7e7d7c  pqrstuvwxyz{|}~.
>>   */
>> +
>> +#define HEX_LINE_SIZE 200
>> +
>>  void print_hex_dump(const char *level, const char *prefix_str, int
>>  prefix_type,
>>     int rowsize, int groupsize,
>>     const void *buf, size_t len, bool ascii)
>>  {
>>   const u8 *ptr = buf;
>>   int i, linelen, remaining = len;
>> -	unsigned char linebuf[200];
>> +	unsigned char *linebuf;
>> +
>> +	linebuf = kmalloc(HEX_LINE_SIZE, GFP_KERNEL);
>> +	if (!linebuf) {
>> +		WARN_ON(1);
>> +		return;
>> +	}
>>  

I'd add GFP_ATOMIC here. Who knows whether tomorrow, the oops dumper
or warn_on will use print_hex_dump.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/