linux-kernel - Re: [PATCH] Fix forgotten module release in xt_CONNMARK and xt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Nov 2007 23:28:20 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
CC:	Netfilter Developer Mailing List 
	<netfilter-devel@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	davem@...emloft.net, stable@...nel.org
Subject: Re: [PATCH] Fix forgotten module release in xt_CONNMARK and xt_CONNSECMARK

Jan Engelhardt wrote:
> Fix forgotten module release in xt_CONNMARK and xt_CONNSECMARK
>
>
> When xt_CONNMARK is used outside the mangle table and the user specified
> "--restore-mark", the connmark_tg_check() function will (correctly)
> error out, but (incorrectly) forgets to release the L3 conntrack module.
> Same for xt_CONNSECMARK.
> Fix is to move the call to acquire the L3 module after the basic 
> constraint checks.
>   

Applied, thanks Jan.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/