linux-kernel - Re: [PATCH x86/mm 05/11] x86 ptrace getreg/putreg merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071129222842.9613826F8E7@magilla.localdomain>
Date:	Thu, 29 Nov 2007 14:28:42 -0800 (PST)
From:	Roland McGrath <roland@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH x86/mm 05/11] x86 ptrace getreg/putreg merge

> This didn't need to be implemented as a macro hence it shouldn't have been.

Ok.


diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index b3433e1..0000000 100644  
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -45,8 +45,10 @@
 /*
  * Determines whether a value may be installed in a segment register.
  */
-#define invalid_selector(value) \
-	((value) != 0 && ((value) & SEGMENT_RPL_MASK) != USER_RPL)
+static inline bool invalid_selector(u16 value)
+{
+	return unlikely(value != 0 && (value & SEGMENT_RPL_MASK) != USER_RPL);
+}
 
 #ifdef CONFIG_X86_32
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/