linux-kernel - Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Nov 2007 17:43:26 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Mark Lord <lkml@....ca>
cc:	Greg KH <gregkh@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...l.org>,
	<linux-usb-devel@...ts.sourceforge.net>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to
 insert/remove race (v3)

On Thu, 29 Nov 2007, Mark Lord wrote:

> Alan Stern wrote:
> > On Thu, 29 Nov 2007, Mark Lord wrote:
> > 
> >>> So again, the problem is in the higher up scsi layer, and that is where
> >>> the problem should already be fixed.
> >> ..
> >>
> >> Ahhh.. so you figure the Oops should also have been fixed
> >> as part of the 2.6.24 SCSI fixes ?  That's what I was missing here.
> > 
> > Yes indeed.  I wish I could point you to the exact patch containing the 
> > fix, but the git software seems to have lost track of it (it's combined
> > in with a large number of other patches with no obvious way to separate 
> > it out).  It's also available in the various mailing list archives, but 
> > I don't have a pointer to it and there's no reasonable way to search 
> > for it.
> > 
> > The patch in question was written by Matthew Wilcox; it added code to 
> > the SCSI async-scanning routines to utilize the scan_mutex.  IMO it 
> > should have been applied to 2.6.23 but it wasn't.

Wait -- I found it:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=6b7f123f378743d739377871c0cbfbaf28c7d25a

Try applying that to 2.6.23 (it should merge with minimal problems)
and do your stress testing again.  Note also the date the patch was 
submitted: June 26.

> Ahh.  Well, thanks for the *great* followup, Alan!

You're welcome.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/