linux-kernel - Re: RFC - organize include/linux/kernel.h, add include/linux/logging.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071130092842.GA6221@localhost.sw.ru>
Date:	Fri, 30 Nov 2007 12:28:43 +0300
From:	Alexey Dobriyan <adobriyan@...ru>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: RFC - organize include/linux/kernel.h, add include/linux/logging.h

> kernel.h has become a bit disorganized over a long time.
> Here's an attempt to clean it up a bit.
> 
> Something for everyone to like or dislike...

You duplicate ALIGN macros all over the place.

> Groups externs and functions by module/function
> Creates a "logging.h" for printk, KERN_<level>
> Changes some macros to statement expressions
> 	DIV_ROUND_UP, roundup and __ALIGN_MASK
> Removes the unused PTR_ALIGN

> This one used the ALIGN macro, but I'm not inclined to
> figure out what it actually does right now, so copy
> the old macro to this file and renames it.

Which is not acceptable. Ditto for DIV_ROUND_UP.

And you somehow decided that putting statements on one line is more
readable than on multiple lines -- typecheck and friends.

Overall impression -- moving code just because you can.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/