linux-kernel - Re: [PATCH] [RESEND] crypto test: use print_hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91b13c310711291720p1dde31b9k1f974025b01703cf@mail.gmail.com>
Date:	Fri, 30 Nov 2007 09:20:34 +0800
From:	"rae l" <crquan@...il.com>
To:	"Herbert Xu" <herbert@...dor.apana.org.au>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Richard Knutsson" <ricknu-0@...dent.ltu.se>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	dengxw@....com, "Randy Dunlap" <randy.dunlap@...cle.com>,
	"Joe Perches" <joe@...ches.com>
Subject: Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead

On Nov 29, 2007 7:13 PM, Herbert Xu <herbert@...dor.apana.org.au> wrote:
...
> > uninlining this function shrinks crypto/tcrypt.o's .text from 20,009 bytes
> > down to 19,701.
> >
> > inlining is almost always wrong.
>
> I agree.  Please do as Andrew suggests and resubmit.
inline disabled.

Cc: Randy Dunlap <randy.dunlap@...cle.com>
Signed-off-by: Denis Cheng <crquan@...il.com>
---

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index 24141fb..13efc72 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -83,10 +83,9 @@ static char *check[] = {

 static void hexdump(unsigned char *buf, unsigned int len)
 {
-	while (len--)
-		printk("%02x", *buf++);
-
-	printk("\n");
+	print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET,
+			16, 1,
+			buf, len, false);
 }

 static void tcrypt_complete(struct crypto_async_request *req, int err)

-- 
Denis Cheng
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/