linux-kernel - Re: [patch] ata: ahci: Enclosure Management via LED rev2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4751EE36.6050506@garzik.org>
Date:	Sat, 01 Dec 2007 18:28:54 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	kristen.c.accardi@...el.com
CC:	akpm@...ux-foundation.org, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] ata: ahci: Enclosure Management via LED rev2

Kristen Carlson Accardi wrote:
> Enclosure Management via LED
> 
> This patch implements Enclosure Management via the LED protocol as specified
> in AHCI specification.
> 
> Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@...el.com>
> ---
> This revision makes the change to the comment requested by Mark Lord,
> fixes some bugs in the bit shifting for writing the new led state,
> and implements a show function so that led status can be read as
> well as written.

Overall looks pretty good, from a technical review perspective.

Two worries:

1) exporting ata_scsi_find_dev(), and assuming a scsi device is 
attached.  the latter can be fixed by a !NULL check (and should be), but 
its a bit of a layering violation since long term we want to make the 
SCSI simulator optional for all ATA devices.

2) vaguely related to #1, I'm not so sure the attributes should be 
implemented directly in ahci.  if this __or something like it__ appears 
on non-Intel hardware, the code should be somewhere more generic.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/