linux-kernel - Re: [PATCH] ipwireless_cs driver for 4G PC Card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1196505933.12292.58.camel@violet>
Date:	Sat, 01 Dec 2007 11:45:33 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	dsterba@...e.cz
Cc:	linux-kernel@...r.kernel.org, linux-pcmcia@...ts.infradead.org,
	akpm@...ux-foundation.org, jeff@...zik.org, jkosina@...e.cz,
	jslaby@...e.cz, stephen@...metric.co.nz, benm@...metric.co.nz
Subject: Re: [PATCH] ipwireless_cs driver for 4G PC Card

Hi David,

> I'm submitting driver for IPWireless PC Card, used for 4G
> internet connection.
> The driver has been in -mm series as ipwireless_cs.git tree for
> some time, is actively used and there are currently no
> outstanding bugs.
> 
> I'd like to let the driver pass through LKML and then let it
> queue for 2.6.25.
> 
> Driver is released under GPL, original authorship belongs to
> Symmetric co. Jiri Kosina has fixed some bugs and made it work
> with recent kernels, and I work on improving the code to
> match linux kernel standards.
> 
> When merged, please drop ipwireless_cs.git tree from -mm and
> include the patch instead. Patches should be sent to me and I'll
> push them to mainline via Jeff Garzik's driver tree, if there's
> no objection.
> 
> Driver lives in drivers/char/pcmcia directory, it's a serial
> driver.  I'm not sure if this is the right place, since it's a
> networking driver too and therefore should be in
> drivers/net/pcmcia.
> 
> There will be a wiki with info for users and developers, todo etc.
> 
> Regards,
> David Sterba
> 
> Rewieved-by: Jiri Slaby <jslaby@...e.cz>
> Signed-off-by: Ben Martel <benm@...metric.co.nz>
> Signed-off-by: Stephen Blackheath <stephen@...metric.co.nz>
> Signed-off-by: David Sterba <dsterba@...e.cz>
> Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> ---
>  MAINTAINERS                                        |    8 
>  drivers/char/pcmcia/Kconfig                        |    8 
>  drivers/char/pcmcia/Makefile                       |    4 
>  drivers/char/pcmcia/ipwireless_cs_hardware.c       | 1728 +++++++++++++++++++++
>  drivers/char/pcmcia/ipwireless_cs_hardware.h       |   63 
>  drivers/char/pcmcia/ipwireless_cs_main.c           |  479 +++++
>  drivers/char/pcmcia/ipwireless_cs_main.h           |   70 
>  drivers/char/pcmcia/ipwireless_cs_network.c        |  496 ++++++
>  drivers/char/pcmcia/ipwireless_cs_network.h        |   54 
>  drivers/char/pcmcia/ipwireless_cs_setup_protocol.h |  108 +
>  drivers/char/pcmcia/ipwireless_cs_tty.c            |  779 +++++++++
>  drivers/char/pcmcia/ipwireless_cs_tty.h            |   48 
>  12 files changed, 3845 insertions(+)

can we please drop the stupid "_cs" stuff. It is an old habit to have
the shortcut for "Card Services" in the driver name, but that goes back
to the time when the PCMCIA subsystem and its drivers were an external
package. Especially in cases where only a PCMCIA card exists, it makes
no sense anymore.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/