linux-kernel - Re: nfsd bug: create file with specific uid/gid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01bf01c8340e$63e90060$6501a8c0@BODDINGTON>
Date:	Sat, 1 Dec 2007 11:36:18 -0000
From:	"Roger Willcocks" <roger@...mlight.ltd.uk>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	<linux-kernel@...r.kernel.org>, <nfs@...ts.sourceforge.net>,
	"Neil Brown" <neilb@...e.de>
Subject: Re: nfsd bug: create file with specific uid/gid

J. Bruce Fields wrote:

> On Fri, Nov 30, 2007 at 05:06:03PM +0000, Roger Willcocks wrote:
>> nfsd/vfs.c:nfsd_create (the v2 version of create) says:
>>
>> "Set file attributes. Mode has already been set and
>> setting uid/gid works only for root"
>>
>> but it doesn't actually test for root-ness
...
> Assignments (especially with things like &=) inside of conditionals
> always make my head hurt for some reason.  So maybe something like the
> below?

The patch looks fine to me, note that nfsd_create_v3 needs fixing too.

>
> Thanks for the bug report!  (And, by the way, how did you run across
> this?)
>

I'm working on an NFSp-like server for our clustered file system and my data 
file creates were not working as expected.

--
Roger

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/