[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <m1abot524h.fsf@ebiederm.dsl.xmission.com>
Date: Sat, 01 Dec 2007 18:14:38 -0700
From: ebiederm@...ssion.com (Eric W. Biederman)
To: Jiri Slaby <jirislaby@...il.com>
Cc: Mark Lord <lkml@....ca>, Arjan van de Ven <arjan@...radead.org>,
Stephen Hemminger <shemminger@...ux-foundation.org>,
Alan Cox <alan@...rguk.ukuu.org.uk>,
Greg Kroah-Hartman <gregkh@...e.de>, Greg KH <greg@...ah.com>,
Tejun Heo <htejun@...il.com>,
Linux Containers <containers@...ts.osdl.org>,
netdev@...r.kernel.org, cornelia.huck@...ibm.com,
stern@...land.harvard.edu, kay.sievers@...y.org,
linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
Herbert Xu <herbert@...dor.apana.org.au>,
David Miller <davem@...emloft.net>,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: namespace support requires network modules to say "GPL"
Jiri Slaby <jirislaby@...il.com> writes:
> On 12/02/2007 12:13 AM, Eric W. Biederman wrote:
>> Mark Lord <lkml@....ca> writes:
>>> Fine. But all of them want to call sk_alloc(),
>>
>> network drivers should be calling sk_alloc less then they should
>> call dev_get_by_XXXX. Only protocols call sk_alloc.
>>
>>> and many want to do register_netdev().
>>
>> I haven't even touched register_netdev.
>>
>>> So what should they be using there ?
>>
>> What are you having problems with?
>>
>> It is hard to answer specific questions without a context.
>
> VMware vmnet.
With a quick glance in that direction it appears to the result
of a design bug in vmnet that they call sk_alloc at all, and someone
seems to have found a work around in vmnet for this situation.
My gut feel is that vmware should just use tun or tap (whichever
is the appropriate one), and be done with it.
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists