linux-kernel - Re: [lm-sensors] [PATCH 1/1] HWMON: coretemp, suspend fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200712022136.48511.rjw@sisk.pl>
Date:	Sun, 2 Dec 2007 21:36:47 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	"Mark M. Hoffman" <mhoffman@...htlink.com>
Cc:	Jiri Slaby <jirislaby@...il.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, lm-sensors@...sensors.org
Subject: Re: [lm-sensors] [PATCH 1/1] HWMON: coretemp, suspend fix

On Sunday, 2 of December 2007, Mark M. Hoffman wrote:
> Hi:
> 
> * Rafael J. Wysocki <rjw@...k.pl> [2007-12-01 00:51:40 +0100]:
> > On Saturday, 1 of December 2007, Rafael J. Wysocki wrote:
> > > On Friday, 30 of November 2007, Jiri Slaby wrote:
> > > > On 11/30/2007 11:15 PM, Jean Delvare wrote:

[--snip--]
> 
> PS: while reading kernel/power/disk.c, I saw this...
> 
> 335 static void power_down(void)
> 336 {
> 337         switch (hibernation_mode) {
> 338         case HIBERNATION_TEST:
> 339         case HIBERNATION_TESTPROC:
> 340                 break;
> 341         case HIBERNATION_REBOOT:
> 342                 kernel_restart(NULL);
> 343                 break;
> 344         case HIBERNATION_PLATFORM:
> 345                 hibernation_platform_enter();
> 346         case HIBERNATION_SHUTDOWN:
> 347                 kernel_power_off();
> 348                 break;
> 349         }
> 350         kernel_halt();
> 351         /*
> 352          * Valid image is on the disk, if we continue we risk serious data
> 353          * corruption after resume.
> 354          */
> 355         printk(KERN_CRIT "Please power me down manually\n");
> 356         while(1);
> 357 }
> 
> Shouldn't that be while(1) cpu_relax(); ?

Yes, it should.

Thanks for pointing that out, I'll fix it.

Greetings,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/