linux-kernel - Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 1 Dec 2007 20:48:25 -0800
From:	Greg KH <gregkh@...e.de>
To:	rae l <crquan@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Since sysfs_mount is static and used only in sysfs_init
	function, it could be just an automatic variable.

On Sun, Dec 02, 2007 at 04:31:09AM +0800, rae l wrote:
> ---
> and I still have questions about this code:
> 1. Why here kern_mount is needed?
> 	Or the first time user space `mount -t sysfs` won't do that?
> 2. If root executes many mounts to mount sysfs on /sys and many other places,
> 	are there many instances of struct vfsmount those have only
> mnt_mountpoint different?
> 
> 	For most common case, mount a virtual filesystem(proc, sysfs, ...) on
> multiple mounting point,
> 	how to handle it more efficiently?
> 
> and where is a detailed explaination on kern_mount? could someone give
> some comments or documentation pointers on this?

See the patches that Eric Biederman just posted to lkml for why this
structure is a static pointer this way right now, it's in preparation
for future patches.

Hope this helps,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/