linux-kernel - Re: [PATCH] keyspan: init termios properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 2 Dec 2007 13:57:34 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	bbpetkov@...oo.de
Cc:	yme@...lum.tnic, Lucy McCoy <lucy@...span.com>,
	Andrew Morton <akpm@...ux-foundation.org>, greg@...ah.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] keyspan: init termios properly

On Sun, 2 Dec 2007 09:03:40 +0100
Borislav Petkov <yme@...lum.tnic> wrote:

> On Fri, Nov 30, 2007 at 09:23:43AM -0800, Lucy McCoy wrote:
> > Hi All,
> >
> > I've been too busy to get to this but i'd rather not use the code fragment 
> > i sent Boris to try.  It would be better to go ahead with the tty setup if 
> > the pointer is not NULL, otherwise use the defaults and not reference the 
> > NULL pointer. I'll see if I can get to this today.
> you might also want to take a look at usa90_indat_callback() - there is
> port->tty accessed again and this time it kills the machine completely when
> something is sent over the serial line from the other end (through minicom, for
> example). Oops is at
> 
> http://www.screenshots.cc/view_image/ab9a1837/cimg00772.jpg

Change it to if (tty && urb->actual_length) in that function and it'll
probably cure it
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/