linux-kernel - Re: [PATCH 1/3] signal(i386): alternative signal stack wraparound occurs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071204130218.GE31590@elte.hu>
Date:	Tue, 4 Dec 2007 14:02:18 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Shi Weihua <shiwh@...fujitsu.com>
Cc:	roland@...hat.com, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 1/3] signal(i386): alternative signal stack wraparound
	occurs


* Shi Weihua <shiwh@...fujitsu.com> wrote:

> > When it's the handler function itself or its callees that cause the 
> > overflow, rather than the signal handler frame setup alone crossing 
> > the boundary, this still won't help.  But I don't see any way to 
> > distinguish that from the valid longjmp case.
> 
> Thank you for your detailed explanation and patch. I tested your 
> patch, unfortunately it can not stop all kinds of overflow.
[...]
> So, the patch I posted is still needed 

thanks, i've picked up your fix for x86.git, for 2.6.25 merging.

> Surely, adding a variable to sched.h is not a good idea. 
> Could you tell me a better place to store the previous esp?

i think sched.h is ok - it has a sas_ss_sp field already. Alternatively, 
if we only want this in x86, we could put it into the thread_struct - 
but i think eventually other architectures would want to use this too, 
right?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/