linux-kernel - Re: [local DoS] Re: Linux 2.6.24-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071204160005.GA29783@elte.hu>
Date:	Tue, 4 Dec 2007 17:00:05 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	"Luiz Fernando N. Capitulino" <lcapitulino@...driva.com.br>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	herton@...driva.com.br, dvgevers@...all.nl
Subject: Re: [local DoS] Re: Linux 2.6.24-rc4


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> 
> 
> On Tue, 4 Dec 2007, Luiz Fernando N. Capitulino wrote:
> >
> > 	sched_rr_get_interval(1, NULL);
> 
> Looks like we have a zero "cfs_rq->load.weight".
> 
> Ingo? Both sched_slice() and __sched_slice() do a divide by the 
> runqueue weight, and at least dequeue_task_fair() explicitly checks 
> for that being zero, so clearly zero is a possible value. Hmm?

yeah, i can reproduce this crash too.

The problem is on SMP: if sched_rr_get_interval() gets a task from an 
otherwise idle runqueue, then rq->load.weight is 0. Normally 
sched_slice() is only used on a busy runqueue. So the correct fixup site 
is not in sched_slice() but in sys_sched_rr_get_interval() - i'm working 
on the right fix, i hope to be able to send a pull request in a few 
minutes.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/