linux-kernel - Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0712040856j530c1389l82adafcba07b89ae@mail.gmail.com>
Date:	Tue, 4 Dec 2007 11:56:54 -0500
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Alessandro Zummo" <alessandro.zummo@...ertech.it>
Cc:	rtc-linux@...glegroups.com, "Bryan Wu" <bryan.wu@...log.com>,
	linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	"Mike Frysinger" <michael.frysinger@...log.com>
Subject: Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz

On Dec 4, 2007 11:49 AM, Alessandro Zummo <alessandro.zummo@...ertech.it> wrote:
> On Tue, 4 Dec 2007 11:47:56 -0500
> "Mike Frysinger" <vapier.adi@...il.com> wrote:
> > the return of ENOTTY is to say "changing of freq isnt supported", not
> > that the value is invalid.  but i can get the same behavior by
> > deleting the function as the rtc-dev layer will take care of returning
> > ENOTTY.
> >
> > so the behavior is for the RTC_IRQP_SET ioctl:
> >  - return ENOTTY if you cannot change freq
> >    - the rtc-dev layer will do this for you if you do not set irq_set_freq
> >  - return EINVAL if the requested freq is not within the capabilities
> > of the hardware
> >
> > sound about right ?
>
>  yes, it is. I agree about deleting it.

so, merge this patch and i'll follow up with another to delete the
func and update the documentation ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/