linux-kernel - Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8bd0f97a0712040915p22117ba8w497e01edc9506507@mail.gmail.com>
Date:	Tue, 4 Dec 2007 12:15:46 -0500
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Alessandro Zummo" <alessandro.zummo@...ertech.it>
Cc:	rtc-linux@...glegroups.com, "Bryan Wu" <bryan.wu@...log.com>,
	linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	"Mike Frysinger" <michael.frysinger@...log.com>
Subject: Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz

On Dec 4, 2007 11:41 AM, Alessandro Zummo <alessandro.zummo@...ertech.it> wrote:
>  it should be EINVAL. at least it is wat rtc-cmos does when the value
>  is invalid.

in the example rtc test code (Documentation/rtc.txt), would it be
useful to handle EINVAL ?  if the freq isnt supported, just say
"hardware does not support frequency %i" and continue on to try the
next freq ?  the current code just does:
perror("RTC_IRQP_SET ioctl");
exit(errno);
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/