linux-kernel - Re: [PATCH] sata_nv: don't use legacy DMA in ADMA mode (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4755A44A.90003@garzik.org>
Date:	Tue, 04 Dec 2007 14:02:34 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Robert Hancock <hancockr@...w.ca>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	ide <linux-ide@...r.kernel.org>, Tejun Heo <htejun@...il.com>,
	Peer Chen <pchen@...dia.com>, Kuan Luo <kluo@...dia.com>,
	Allen Martin <AMartin@...dia.com>
Subject: Re: [PATCH] sata_nv: don't use legacy DMA in ADMA mode (v3)

Robert Hancock wrote:
> We need to run any DMA command with result taskfile requested in ADMA mode
> when the port is in ADMA mode, otherwise it may try to use the legacy DMA engine
> in ADMA mode which is not allowed. Enforce this with BUG_ON() since data
> corruption could potentially result if this happened. Also, fail any attempt to
> try and issue NCQ commands with result taskfile requested, since the hardware
> doesn't allow this.
> 
> Signed-off-by: Robert Hancock <hancockr@...w.ca>

applied #upstream-fixes

Please make sure to copy relevant NVIDIA engineers on your patches, 
since they are actively contributing patches to Linux too (and, well, 
its their hardware :))

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/