[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4755A809.4050305@qumranet.com>
Date: Tue, 04 Dec 2007 21:18:33 +0200
From: Avi Kivity <avi@...ranet.com>
To: Glauber de Oliveira Costa <gcosta@...hat.com>
CC: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
glommer@...il.com, tglx@...utronix.de, mingo@...e.hu,
ehabkost@...hat.com, jeremy@...p.org, anthony@...emonkey.ws,
virtualization@...ts.linux-foundation.org, rusty@...tcorp.com.au,
ak@...e.de, chrisw@...s-sol.org, rostedt@...dmis.org, hpa@...or.com
Subject: Re: [PATCH 4/8] unify paravirt parts of system.h
Glauber de Oliveira Costa wrote:
> This patch moves the i386 control registers manipulation functions,
> wbinvd, and clts functions to system.h. They are essentially the same
> as in x86_64, except for the cr8 register, which we add.
>
> +
> +static inline unsigned long native_read_cr8(void)
> +{
> + unsigned long cr8;
> + asm volatile("mov %%cr8,%0" : "=r" (cr8), "=m" (__force_order));
> + return cr8;
> +}
> +
>
There is no cr8 register on i386. This had better be protected by an
#ifdef.
(you're likely not getting an error since it's a static inline, so the
asm is never emitted)
--
Any sufficiently difficult bug is indistinguishable from a feature.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists