linux-kernel - Re: Regression - 2.6.24-rc3 - umem nvram card driver oops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071204093716.GB4541@elte.hu>
Date:	Tue, 4 Dec 2007 10:37:16 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Neil Brown <neilb@...e.de>
Cc:	David Chinner <dgc@....com>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: Regression - 2.6.24-rc3 - umem nvram card driver oops


* Neil Brown <neilb@...e.de> wrote:

> ### Diffstat output
>  ./drivers/block/umem.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff .prev/drivers/block/umem.c ./drivers/block/umem.c
> --- .prev/drivers/block/umem.c	2007-12-04 11:11:30.000000000 +1100
> +++ ./drivers/block/umem.c	2007-12-04 11:11:42.000000000 +1100
> @@ -484,7 +484,8 @@ static void process_page(unsigned long d
>  		page->idx++;
>  		if (page->idx >= bio->bi_vcnt) {
>  			page->bio = bio->bi_next;
> -			page->idx = page->bio->bi_idx;
> +			if (page->bio)
> +				page->idx = page->bio->bi_idx;
>  		}
>  
>  		pci_unmap_page(card->dev, desc->data_dma_handle,

btw., if anyone feels so inclined, this file has quite a number of 
coding style issues, as per scripts/checkpatch.pl output:

 total: 28 errors, 54 warnings, 1221 lines checked

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/