linux-kernel - Re: [build bug] undefined reference to `dib3000mc_get_tuner_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0712041130310.16564@twin.jikos.cz>
Date:	Tue, 4 Dec 2007 11:32:53 +0100 (CET)
From:	Jiri Kosina <jikos@...os.cz>
To:	Ingo Molnar <mingo@...e.hu>
cc:	linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Patrick Boettcher <pb@...uxtv.org>,
	Marcel Holtmann <marcel@...tmann.org>
Subject: Re: [build bug] undefined reference to `dib3000mc_get_tuner_i2c_master'

On Tue, 4 Dec 2007, Ingo Molnar wrote:

> with the attached config i get this build failure:
>  drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach':
>  : undefined reference to `dib3000mc_get_tuner_i2c_master'
>  drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach':
>  : undefined reference to `dib3000mc_set_config'
> on 2.6.24-rc-latest.

Hmm, seems like -common part contains also code that is not completely 
common to all the modules.

How about this?



From: Jiri Kosina <jkosina@...e.cz>

DVB: Compile 3000MC-specific DIB code only for CONFIG_DVB_DIB3000MC

Signed-off-by: Jiri Kosina <jkosina@...e.cz>

diff --git a/drivers/media/dvb/dvb-usb/dibusb-common.c b/drivers/media/dvb/dvb-usb/dibusb-common.c
index 9a184da..b95b1eb 100644
--- a/drivers/media/dvb/dvb-usb/dibusb-common.c
+++ b/drivers/media/dvb/dvb-usb/dibusb-common.c
@@ -223,6 +223,7 @@ static struct dibx000_agc_config dib3000p_panasonic_agc_config = {
 	.agc2_slope2 = 0x1e,
 };
 
+#ifdef CONFIG_DVB_DIB3000MC
 static struct dib3000mc_config mod3000p_dib3000p_config = {
 	&dib3000p_panasonic_agc_config,
 
@@ -305,6 +306,7 @@ int dibusb_dib3000mc_tuner_attach(struct dvb_usb_adapter *adap)
 	return 0;
 }
 EXPORT_SYMBOL(dibusb_dib3000mc_tuner_attach);
+#endif
 
 /*
  * common remote control stuff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/