lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 5 Dec 2007 11:11:55 +0100
From:	Nick Piggin <npiggin@...e.de>
To:	Aaron Carroll <aaronc@...ato.unsw.edu.au>
Cc:	Jens Axboe <jens.axboe@...cle.com>, linux-kernel@...r.kernel.org,
	Peter Chubb <peterc@...ato.unsw.edu.au>
Subject: Re: [PATCH] as-iosched: fix incorrect comments

On Wed, Dec 05, 2007 at 09:06:50PM +1100, Aaron Carroll wrote:
> Two comments refer to deadlines applying to reads only.  This is
> not the case.
> 
> Signed-off-by: Aaron Carroll <aaronc@...ato.unsw.edu.au>

Acked-by: Nick Piggin <npiggin@...e.de>

> ---
>  block/as-iosched.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/as-iosched.c b/block/as-iosched.c
> index dc715a5..4513fc5 100644
> --- a/block/as-iosched.c
> +++ b/block/as-iosched.c
> @@ -880,7 +880,7 @@ static void as_remove_queued_request(struct request_queue *q,
>  }
>  
>  /*
> - * as_fifo_expired returns 0 if there are no expired reads on the fifo,
> + * as_fifo_expired returns 0 if there are no expired requests on the fifo,
>   * 1 otherwise.  It is ratelimited so that we only perform the check once per
>   * `fifo_expire' interval.  Otherwise a large number of expired requests
>   * would create a hopeless seekstorm.
> @@ -1159,7 +1159,7 @@ static void as_add_request(struct request_queue *q, struct request *rq)
>  	as_add_rq_rb(ad, rq);
>  
>  	/*
> -	 * set expire time (only used for reads) and add to fifo list
> +	 * set expire time and add to fifo list
>  	 */
>  	rq_set_fifo_time(rq, jiffies + ad->fifo_expire[data_dir]);
>  	list_add_tail(&rq->queuelist, &ad->fifo_list[data_dir]);
> -- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists