linux-kernel - Re: [-mm PATCH] kallsyms should prefer non weak symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071204190923.f5037693.akpm@linux-foundation.org>
Date:	Tue, 4 Dec 2007 19:09:23 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Paulo Marques <pmarques@...popie.com>
Cc:	linux-kernel@...r.kernel.org,
	Mathieu Desnoyers <compudj@...stal.dyndns.org>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [-mm PATCH] kallsyms should prefer non weak symbols

On Tue, 04 Dec 2007 20:35:32 +0000 Paulo Marques <pmarques@...popie.com> wrote:

> When resolving symbol names from addresses with aliased symbol names, 
> kallsyms_lookup always returns the first symbol, even if it is a weak 
> symbol.
> 
> This patch changes this by sorting the symbols with the weak symbols 
> last before feeding them to the kernel. This way the kernel runtime 
> isn't changed at all, only the kallsyms build system is changed.
> 
> Another side effect is that the symbols get sorted by address, too. So, 
> even if future binutils version have some bug in "nm" that makes it fail 
> to correctly sort symbols by address, the kernel won't be affected by this.
> 
> 
> From: Paulo Marques <pmarques@...popie.com>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>

The signoffs don't make sense.

If you authored the patch then please put a From: at the top of the changelog
and include your signed-off-by:.

If Mathieu worked on or forwarded the patch then include his s-o-b.
If he wasn't in the delivery path but has tested/reviewed/approved the
patch then Acked-by: is more appropriate.  Documentation/SubmittingPatches
has details...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/