linux-kernel - Re: [patch 06/18] ieee1394: nopage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071205235256.GE5617@wotan.suse.de>
Date:	Thu, 6 Dec 2007 00:52:56 +0100
From:	Nick Piggin <npiggin@...e.de>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	akpm@...ux-foundation.org, krh@...hat.com,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [patch 06/18] ieee1394: nopage

On Wed, Dec 05, 2007 at 02:15:35PM +0100, Stefan Richter wrote:
> > npiggin@...e.de wrote:
> >> @@ -275,7 +270,7 @@ int dma_region_mmap(struct dma_region *d
> >>  	if (!dma->kvirt)
> >>  		return -EINVAL;
> >>  
> >> -	/* must be page-aligned */
> >> +	/* must be page-aligned (XXX: comment is wrong, we could allow pgoff) */
> >>  	if (vma->vm_pgoff != 0)
> >>  		return -EINVAL;
> >>  
> > 
> > Are you sure that the comment is wrong?  Could it be that there are
> > assumptions elsewhere which require page alignment?  (I should be able
> > to answer that, but I'm not.)
> 
> PS:  Assumed the comment is wrong, is the code wrong then too?

The mmap / fault code _seems_ OK. The check here is only wrong in that it
doesn't prevent non-page-aligned mappings (the core VM code already does).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/