lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 05 Dec 2007 16:11:49 +0900
From:	Tejun Heo <htejun@...il.com>
To:	WANG Cong <xiyou.wangcong@...il.com>
CC:	sam@...nborg.org, Linux Kernel <linux-kernel@...r.kernel.org>,
	notting@...hat.com, rusty@...tcorp.com.au, kay.sievers@...y.org,
	greg@...ah.com
Subject: Re: [PATCH] kbuild: implement modules.order

WANG Cong wrote:
>>> I think, you forgot to free(3) the memory you calloc(3)'ed and
>>> malloc(3)'ed above.
>> It's a simple program where whole body is in main().  Why bother?
>> What's the benefit of adding hash-table iterating free logic?
>>
> 
> Personally, I think memory leaks are bugs. And we hate bugs. ;)

Trust me.  As a person buried alive in bug reports, I hate bugs too.  I
just don't agree that this type of programs should free all its
resources before exiting.  How about adding a comment saying /* we're
going out anyway, don't bother freeing hashtable */?

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists