linux-kernel - Re: [patch] ext2: xip check fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4757B62F.2040608@de.ibm.com>
Date:	Thu, 06 Dec 2007 09:43:27 +0100
From:	Carsten Otte <cotte@...ibm.com>
To:	Nick Piggin <npiggin@...e.de>
CC:	carsteno@...ibm.com,
	Christian Borntraeger <borntraeger@...ibm.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>, rob@...dley.net,
	Jens Axboe <axboe@...nel.dk>
Subject: Re: [patch] ext2: xip check fix

Nick Piggin wrote:
>> Xip does only work, if both do match PAGE_SIZE because it 
>> does'nt support multiple calls to direct_access in the get_xip_page 
>> address space operation. Thus we check both here, actually this was 
>> changed from how it looks after your patch as a bugfix where our 
>> tester tried a 4k filesystem on a 2k blockdev.
>> Did I miss something?
> 
> However, the bdev block size may be changed with sb_set_blocksize. It
> doesn't actually have to match the hardware sector size -- if this
> does matter for XIP, then I think you need some other check here.
Hmmmmhh. For a bdev with PAGE_SIZE hardsect size, there is no other 
valid value then PAGE_SIZE that one could set it to. Or can it indeed 
be changed to a value greater then PAGE_SIZE or smaller then hardsect 
size?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/