linux-kernel - Re: [PATCH 10/20] drivers/scsi/ipr.c: use LIST_HEAD instead of LIST_HEAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47582BCF.3070706@linux.vnet.ibm.com>
Date:	Thu, 06 Dec 2007 11:05:19 -0600
From:	Brian King <brking@...ux.vnet.ibm.com>
To:	Denis Cheng <crquan@...il.com>
CC:	linux-scsi@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/20] drivers/scsi/ipr.c: use LIST_HEAD instead of LIST_HEAD_INIT

Acked-by: Brian King <brking@...ux.vnet.ibm.com>

Denis Cheng wrote:
> single list_head variable initialized with LIST_HEAD_INIT could almost
> always can be replaced with LIST_HEAD declaration, this shrinks the code
> and looks better.
> 
> Signed-off-by: Denis Cheng <crquan@...il.com>
> ---
>  drivers/scsi/ipr.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
> index 0841df0..9018ee8 100644
> --- a/drivers/scsi/ipr.c
> +++ b/drivers/scsi/ipr.c
> @@ -84,7 +84,7 @@
>  /*
>   *   Global Data
>   */
> -static struct list_head ipr_ioa_head = LIST_HEAD_INIT(ipr_ioa_head);
> +static LIST_HEAD(ipr_ioa_head);
>  static unsigned int ipr_log_level = IPR_DEFAULT_LOG_LEVEL;
>  static unsigned int ipr_max_speed = 1;
>  static int ipr_testmode = 0;


-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/